-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Config] Port 'ConfigExperiment' to Swift #14179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
force-pushed
the
nc/config-configexperiment
branch
from
December 3, 2024 20:47
6d667b7
to
4795a4c
Compare
Apple API Diff ReportCommit: 4404a97 FirebaseABTestingConstants[MODIFIED] FIRDefaultExperimentOverflowPolicy[MODIFIED] FIRDefaultExperimentOverflowPolicySwift:
+ let FIRDefaultExperimentOverflowPolicy : ABTExperimentPayloadExperimentOverflowPolicy
- let FIRDefaultExperimentOverflowPolicy : << error type >>
Objective-C:
+ extern const ABTExperimentPayloadExperimentOverflowPolicy FIRDefaultExperimentOverflowPolicy
- extern const ABTExperimentPayloadExperimentOverflowPolicy FIRDefaultExperimentOverflowPolicy Enumerations[MODIFIED] ABTExperimentPayloadExperimentOverflowPolicy[MODIFIED] ABTExperimentPayloadExperimentOverflowPolicySwift:
+ enum ABTExperimentPayloadExperimentOverflowPolicy : Int32 , @unchecked Sendable
+ case unspecified = 0
+ case discardOldest = 1
+ case unrecognizedValue = 999
+ case ignoreNewest = 2
Objective-C:
+ enum ABTExperimentPayloadExperimentOverflowPolicy : int32_t {}
- NS_ENUM ( int32_t
+ ABTExperimentPayloadExperimentOverflowPolicyUnspecified = 0
+ ABTExperimentPayloadExperimentOverflowPolicyDiscardOldest = 1
+ ABTExperimentPayloadExperimentOverflowPolicyUnrecognizedValue = 999
+ ABTExperimentPayloadExperimentOverflowPolicyIgnoreNewest = 2 ClassesFIRExperimentController[MODIFIED] -updateExperimentsWithServiceOrigin:events:policy:lastStartTime:payloads:completionHandler:Swift:
+ func updateExperiments ( withServiceOrigin origin : String , events : LifecycleEvents , policy : ABTExperimentPayloadExperimentOverflowPolicy , lastStartTime : TimeInterval , payloads : [ Data ]) async throws
Objective-C:
+ - ( void ) updateExperimentsWithServiceOrigin :( nonnull NSString * ) origin events :( nonnull FIRLifecycleEvents * ) events policy : ( ABTExperimentPayloadExperimentOverflowPolicy ) policy lastStartTime : ( NSTimeInterval ) lastStartTime payloads : ( nonnull NSArray < NSData *> * ) payloads completionHandler : ( nullable void ( ^ )( NSError * _Nullable )) completionHandler ;
- - ( void ) updateExperimentsWithServiceOrigin :( nonnull NSString * ) origin events :( nonnull FIRLifecycleEvents * ) events policy : ( ABTExperimentPayloadExperimentOverflowPolicy ) policy lastStartTime : ( NSTimeInterval ) lastStartTime payloads : ( nonnull NSArray < NSData *> * ) payloads completionHandler : ( nullable void ( ^ )( NSError * _Nullable )) completionHandler ; |
ncooke3
commented
Dec 3, 2024
paulb777
approved these changes
Dec 5, 2024
ncooke3
commented
Dec 5, 2024
paulb777
approved these changes
Dec 5, 2024
paulb777
pushed a commit
that referenced
this pull request
Dec 11, 2024
paulb777
pushed a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#no-changelog