Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auth] Remove unnecessary throws on internal methods #14154

Merged
merged 2 commits into from
Nov 20, 2024
Merged

[Auth] Remove unnecessary throws on internal methods #14154

merged 2 commits into from
Nov 20, 2024
+10 −10

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 20, 2024

Methods don't throw, so remove the throws keyword.

#no-changelog

@ncooke3 ncooke3 requested a review from paulb777 November 20, 2024 22:05
@ncooke3 ncooke3 merged commit cb0bc77 into main Nov 20, 2024
55 checks passed
@ncooke3 ncooke3 deleted the nc/unused-throw branch November 20, 2024 22:38
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @paulb777 @google-oss-bot