[Auth] Remove httpMethod from AuthRequestConfiguration #14143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
changed the title
andrewheard
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Thanks, @ncooke3! LGTM, I think it's safer for us to set the right HTTP method instead of relying on GTMSessionFetcher to fix it for us (and will also make migration easier if we ever needed to move to directly using URLSession).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthRequestConfiguration's properties should not be specific to an individual request.In practice, the request is passed to GTMSessionFetcher which will change the httpMethod as necessary: https://github.com/google/gtm-session-fetcher/blob/ef9a60ba09dff71540c8bf612fb778a3af790a7e/Sources/Core/GTMSessionFetcher.m#L721-L732
#no-changelog