Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Schedule keychain access after prewarming #14142

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 18, 2024

Related to #14141. Breaking this into its own PR for easier review.

Fix for some scenarios in #13231 that are related to upgrading to 11.x and prewarming.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find on the issue and nice cleanups. Thanks!

FirebaseAuth/Sources/Swift/Auth/Auth.swift Outdated Show resolved Hide resolved
FirebaseAuth/Sources/Swift/Auth/Auth.swift Outdated Show resolved Hide resolved
@paulb777 paulb777 added this to the 11.6.0 - M157 milestone Nov 18, 2024
@ncooke3 ncooke3 enabled auto-merge (squash) November 18, 2024 21:23
@ncooke3 ncooke3 merged commit 2495c20 into main Nov 18, 2024
43 checks passed
@ncooke3 ncooke3 deleted the nc/refactor-auth branch November 18, 2024 21:24
@firebase firebase locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants