-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra] Migrate away from macos-12 in performance.yml #14131
Conversation
Edit: I think #11903 is still valid because pod gen locally reveals the failures, but it's weird that the tests passed on CI... |
Hmm, looks like xcbeautify doesn't surface a failing exit code when tests crash (cpisciotta/xcbeautify#175): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, looks like xcbeautify doesn't surface a failing exit code when tests crash
This was a good catch. Let's investigate what to do next before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this doesn't fully resolve #11903, moving off of macos-12
will soon be important and the jobs that are changed in this PR (see below) are passing on CI.
firebase-ios-sdk/scripts/build.sh
Lines 637 to 660 in d84d5ef
Performance-*-unit) | |
# Run unit tests on prod environment with unswizzle capabilities. | |
export FPR_UNSWIZZLE_AVAILABLE="1" | |
export FPR_AUTOPUSH_ENV="0" | |
pod_gen FirebasePerformance.podspec --platforms="${gen_platform}" | |
RunXcodebuild \ | |
-workspace 'gen/FirebasePerformance/FirebasePerformance.xcworkspace' \ | |
-scheme "FirebasePerformance-Unit-unit" \ | |
"${xcb_flags[@]}" \ | |
build \ | |
test | |
;; | |
Performance-*-proddev) | |
# Build the prod dev test app. | |
export FPR_UNSWIZZLE_AVAILABLE="0" | |
export FPR_AUTOPUSH_ENV="0" | |
pod_gen FirebasePerformance.podspec --platforms="${gen_platform}" | |
RunXcodebuild \ | |
-workspace 'gen/FirebasePerformance/FirebasePerformance.xcworkspace' \ | |
-scheme "FirebasePerformance-TestApp" \ | |
"${xcb_flags[@]}" \ | |
build | |
;; |
Unlike the spm
jobs, the ones touched in this PR don't appear to be crashing:
performance (iOS, unit)
performance (iOS, proddev)
(build only)performance (tvOS, unit)
performance (tvOS, proddev)
(build only)
Related to #11903
#no-changelog