Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Migrate away from macos-12 in performance.yml #14131

Merged
merged 9 commits into from
Nov 19, 2024
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 15, 2024

Related to #11903

#no-changelog

@ncooke3 ncooke3 changed the title [Infra] Migrate away fromm macos-12 in performance.yml [Infra] Migrate away from macos-12 in performance.yml Nov 15, 2024
@ncooke3
Copy link
Member Author

ncooke3 commented Nov 15, 2024

Edit: I think #11903 is still valid because pod gen locally reveals the failures, but it's weird that the tests passed on CI...

@ncooke3 ncooke3 requested a review from andrewheard November 15, 2024 19:43
@ncooke3
Copy link
Member Author

ncooke3 commented Nov 15, 2024

Hmm, looks like xcbeautify doesn't surface a failing exit code when tests crash (cpisciotta/xcbeautify#175):

https://github.com/firebase/firebase-ios-sdk/actions/runs/11862154195/job/33061011258?pr=14131#step:6:893

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like xcbeautify doesn't surface a failing exit code when tests crash

This was a good catch. Let's investigate what to do next before merging.

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this doesn't fully resolve #11903, moving off of macos-12 will soon be important and the jobs that are changed in this PR (see below) are passing on CI.

Performance-*-unit)
# Run unit tests on prod environment with unswizzle capabilities.
export FPR_UNSWIZZLE_AVAILABLE="1"
export FPR_AUTOPUSH_ENV="0"
pod_gen FirebasePerformance.podspec --platforms="${gen_platform}"
RunXcodebuild \
-workspace 'gen/FirebasePerformance/FirebasePerformance.xcworkspace' \
-scheme "FirebasePerformance-Unit-unit" \
"${xcb_flags[@]}" \
build \
test
;;
Performance-*-proddev)
# Build the prod dev test app.
export FPR_UNSWIZZLE_AVAILABLE="0"
export FPR_AUTOPUSH_ENV="0"
pod_gen FirebasePerformance.podspec --platforms="${gen_platform}"
RunXcodebuild \
-workspace 'gen/FirebasePerformance/FirebasePerformance.xcworkspace' \
-scheme "FirebasePerformance-TestApp" \
"${xcb_flags[@]}" \
build
;;

Unlike the spm jobs, the ones touched in this PR don't appear to be crashing:

@ncooke3 ncooke3 merged commit e8c71d1 into main Nov 19, 2024
41 checks passed
@ncooke3 ncooke3 deleted the nc/mac12-perf branch November 19, 2024 00:03
@firebase firebase locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants