Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Migrate away from macos-12 in sessions-integration-tests.yml #14130

Merged
merged 1 commit into from
Nov 15, 2024
Merged

[Infra] Migrate away from macos-12 in sessions-integration-tests.yml #14130

merged 1 commit into from
Nov 15, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 15, 2024 •
edited
Loading

Test case looks to have passed.

Fixes #12771

#no-changelog

@ncooke3 ncooke3 requested a review from andrewheard November 15, 2024 19:36
andrewheard
andrewheard approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green for https://github.com/firebase/firebase-ios-sdk/actions/runs/11862078737/job/33060719462?pr=14130

@ncooke3 ncooke3 merged commit f981799 into main Nov 15, 2024
25 checks passed
@ncooke3 ncooke3 deleted the nc/mac12-sessions branch November 15, 2024 19:49
@firebase firebase locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sessions Integration Tests] fail running on macos-14
2 participants
@ncooke3 @andrewheard