Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Make AuthBackend and related types Sendable #14125

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 14, 2024

Addresses a couple places where AuthBackend is being sent across concurrency domains. The class is immutable and should be ok to mark Sendable. It does have a dependency on GTMSessionFetcher so preconcurrency imports are being used for those imports to suppress warnings that those type are not sendable.

e.g. Sending 'backend' risks causing data races

#no-changelog

@ncooke3 ncooke3 merged commit 427647b into main Nov 15, 2024
55 checks passed
@ncooke3 ncooke3 deleted the nc/sendable-backend branch November 15, 2024 15:11
@firebase firebase locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants