Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auth] Use result type to wrap completion handlers internally #13563

Merged
merged 17 commits into from
Dec 3, 2024
Merged

[Auth] Use result type to wrap completion handlers internally #13563

merged 17 commits into from
Dec 3, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Aug 31, 2024 •
edited
Loading

Follow-up to #13561

Use Swift's Result type enum to prevent cases where a completion handler is called with both non-nil or both nil.

#no-changelog

@ncooke3 ncooke3 requested a review from paulb777 December 3, 2024 22:06
paulb777
paulb777 approved these changes Dec 3, 2024
View reviewed changes
FirebaseAuth/Tests/Unit/RPCBaseTests.swift Outdated Show resolved Hide resolved
@ncooke3 ncooke3 merged commit 454f399 into main Dec 3, 2024
55 checks passed
@ncooke3 ncooke3 deleted the nc/followup-async branch December 3, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @paulb777 @google-oss-bot