Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auth-swift] Sample app Settings screen 2 #11801

Merged
merged 6 commits into from
Sep 13, 2023
Merged

[auth-swift] Sample app Settings screen 2 #11801

merged 6 commits into from
Sep 13, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Sep 12, 2023 •
edited
Loading

Successor PR to #11723

  • Implement rest of Settings screen UI
  • Implement functionality except for Phone Auth section (needs a device)
  • Fix missing implementation of languageCode API
  • Fix a few more access specifications in Auth.swift
  • Add UI tests for Settings screen

Objective C app screenshot

Screenshot 2023-09-12 at 2 49 52 PM

Swift app screenshot

Screenshot 2023-09-12 at 2 50 59 PM

#no-changelog

ncooke3
ncooke3 approved these changes Sep 13, 2023
View reviewed changes
FirebaseAuth/Sources/Swift/Auth/Auth.swift Show resolved Hide resolved
FirebaseAuth/Sources/Swift/Auth/Auth.swift Outdated Show resolved Hide resolved
morganchen12
morganchen12 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comment

FirebaseAuth/Sources/Swift/Auth/Auth.swift Outdated Show resolved Hide resolved
andrewheard
andrewheard approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FirebaseAuth/Sources/Swift/Auth/Auth.swift Outdated Show resolved Hide resolved
@paulb777 paulb777 merged commit 5aafebe into auth-swift Sep 13, 2023
17 checks passed
@paulb777 paulb777 deleted the pb-settings2 branch September 13, 2023 17:33
@firebase firebase locked and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

@morganchen12 morganchen12 morganchen12 approved these changes

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulb777 @andrewheard @morganchen12 @ncooke3 @google-oss-bot