Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Detect Module changes #11743

Closed
wants to merge 38 commits into from
Closed

Test Detect Module changes #11743

wants to merge 38 commits into from

Conversation

sunmou99
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in a feature request so that we
    can discuss it together.

andrewheard and others added 30 commits August 1, 2023 11:16
@andrewheard
[Release] Update Carthage artifacts for Firebase 10.13.0 (#11637)
f4cf208
@dconeybe
Firestore: FIRQueryTests.mm: Use a different Firestore instance to de…
78b2fea 
…lete documents (#11615)
@andrewheard
Update versions for Release 10.14.0 (#11640)
7da314a
@wu-hui
Setup integration tests against named db (#11638)
54f1b1b 
* Make tests work against named db

* setup jobs
@eldhosembabu
Increase test timeout to de-flake testes in Google3 (#11643)
5a7af33 
Increase test timeout to de-flake testes in Google3
@dconeybe
Firestore: Convert testing_hooks_util.h/cc from C++ to Objective-C in…
a4ee260 
… FSTTestingHooks.h/mm (#11639)
@andrewheard
[CI] Handle empty list in check_copyright.sh (#11647)
e04f324 
- Added handling for an empty list of files with invalid copyright declarations.
- Fixed indentation to 2 spaces.
@MarkDuckworth
Fix: Aggregate query order-by normalization (#11635)
45c3004 
Fix aggregate query order-by normalization to better support future aggregations. This has no affect on count.
@ncooke3
[Core] Fix API misnomer within FIRApp.m (#11648)
d4beb34
@morganchen12
update thread-safety docs on Storage (#11661)
7ad4967
@andrewheard
[App Check] Fix App Attest and DeviceCheck API availability (#11662)
4b9cbf6 
- Updated the FIR_DEVICE_CHECK_PROVIDER_AVAILABILITY and FIR_APP_ATTEST_PROVIDER_AVAILABILITY API availability macros to reflect the set of supported platforms for DeviceCheck (iOS 11+, macOS 10.15+, macCatalyst 13+, tvOS 11+, watchOS 9+) and App Attest (iOS 14+, macOS 11.3+, macCatalyst 14.5+, tvOS 15+, watchOS 9+).

- Removed the extraneous check for the watchOS 9 SDK now that Xcode 14 is the minimum supported by Firebase.
Removed the #if TARGET_OS_IOS compiler directive in AppCheckAPITests.swift since TARGET_OS_IOS is only available in Objective-C and was always false.
@andrewheard
[App Check] Add DeviceCheck isSupported check (#11663)
77fa63d 
Added a DeviceCheck isSupported check and return a FIRAppCheckErrorCodeUnsupported error when not supported (e.g., when running on the simulator or older Macs). This was done to match the behaviour of the FIRAppAttestProvider.
@andrewheard
[visionOS] Fix Sessions SDK build on Xcode 15 beta 6 (#11666)
0e183e0 
In Xcode 15 beta 6, `#if os(iOS)` no longer evaluates to true when building for visionOS.

Note: `TARGET_OS_IOS` continues to be defined so Objective-C code is unchanged.
@andrewheard
[visionOS] Fix Storage SDK build on Xcode 15 beta 6 (#11667)
df56264 
In Xcode 15 beta 6, `#if os(iOS)` no longer evaluates to true when building for visionOS.

Note: `TARGET_OS_IOS` continues to be defined so Objective-C code is unchanged.
@andrewheard
[Combine] Remove canImport(Combine) and swift(>=5.0) checks (#11668)
6a0c4f5 
Firebase 7.2+ requires Xcode 12+, which includes Combine support and Swift 5.3; the canImport(Combine) and swift(>=5.0) checks should now be extraneous.
@danielamitay
Fix mutating array during iteration crash (#11669)
3df15ba
@sunmou99
Fix nightly report (#11671)
8101179
@dconeybe
Firestore: FIRQueryTests.mm: Replace SortedStringsNotIn() custom func…
7a59c55 
…tion (#11649)
@ncooke3
[Docs] Update Package.swift docs (#11686)
f8ba868
@paulb777
Auth reCAPTCHA integration (#11681)
0cddb58 
Co-authored-by: Paul Beusterien <[email protected]>
@paulb777
Allow minor and patch updates to RecaptchaInterop (#11687)
890b81d
@paulb777
10.14.0 Firestore SPM binary update (#11691)
7963cec
@paulb777
Update to TARGET_OS_VISION (#11692)
3995b43
@paulb777
Update Changelog for 10.14.0 (#11685)
8083452
@github-actions
NOTICES Change (#11695)
d65cecb 
Co-authored-by: runner <[email protected]>
@eldhosembabu
Refactoring method names. (#11680)
171f020
Fix a bug where getProjectConfig uses http post (#11698)
009b87b
@paulb777
Fix Auth changelog for 10.14.0 (#11700)
2bfe6ab
@samedson
Update Crashlytics to use Google Utilities deviceSimulatorModel (#11707)
51d9e39
@wu-hui
Run xcodebuild in parallel for firestore (#11708)
3f9fb1b 
This PR includes a few improvements to Firestore's CI jobs:

- Always trigger Firestore workflow, but change the workflow to skip its jobs if no firestore changes are detected.
- Introduce a new job check-required-tests to the workflow to check if all required jobs are successful or skipped. This should be the required check.
Add parallelization parameters to xcodebuild
- Skip a build step with xcodebuild, and only do test which triggers build anyways. This removes a redundant build run.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023 •
edited
Loading

Apple API Diff Report

Commit: c7a5586
Last updated: Tue Aug 29 14:45 PDT 2023
View workflow logs & download artifacts

[BUILD ERROR] GoogleAppMeasurement

@sunmou99 sunmou99 mentioned this pull request Aug 29, 2023
Closed
@sunmou99 sunmou99 closed this Sep 12, 2023
@firebase firebase locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
api: analytics api: appcheck api: appdistribution api: auth api: core api: crashlytics api: database api: dynamiclinks api: firestore api: functions api: inappmessaging Firebase In App Messaging api: installations api: messaging api: performance api: remoteconfig api: storage public-api-change release-tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.