Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test testBloomFilterShouldCorrectlyEncodeComplexUnicodeCharacters to FIRQueryTests.mm #11679

Merged
merged 6 commits into from
Sep 7, 2023
Merged

Add test testBloomFilterShouldCorrectlyEncodeComplexUnicodeCharacters to FIRQueryTests.mm #11679

merged 6 commits into from
Sep 7, 2023

Conversation

dconeybe
Copy link
Contributor

Add test testBloomFilterShouldCorrectlyEncodeComplexUnicodeCharacters to FIRQueryTests.mm. This test verifies that the bloom filter correctly encodes document paths that contain special Unicode characters, like combining characters and characters above 0xFFFF (i.e. characters outside of the BMP, basic multilingual plane).

Googlers see b/289233003 for details.

This is a port of firebase/firebase-js-sdk#7412, firebase/firebase-js-sdk#7413, and firebase/firebase-js-sdk#7474.

#no-changelog

@dconeybe dconeybe self-assigned this Aug 15, 2023
This was referenced Aug 15, 2023
Merged
Merged
Merged
@google-oss-bot
Copy link

google-oss-bot commented Aug 15, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.13% (2eccf79) to 88.19% (73a78b9) by +0.06%.

    FilenameBase (2eccf79)Merge (73a78b9)Diff
    exception.cc23.68%84.21%+60.53%
    filesystem_posix.cc79.09%81.82%+2.73%
    leveldb_key.cc98.82%98.14%-0.69%
    leveldb_mutation_queue.cc93.56%92.42%-1.14%
    leveldb_remote_document_cache.cc96.55%94.83%-1.72%
    remote_event.cc97.67%97.75%+0.07%
    task.cc93.91%94.78%+0.87%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cbNcT93LaZ.html

@dconeybe dconeybe requested a review from milaGGL August 15, 2023 16:50
@dconeybe dconeybe marked this pull request as ready for review August 15, 2023 16:51
milaGGL
milaGGL approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe merged commit 0e3f78b into master Sep 7, 2023
41 checks passed
@dconeybe dconeybe deleted the dconeybe/BloomFilterUnicodeTest branch September 7, 2023 20:05
andrewheard pushed a commit that referenced this pull request Sep 20, 2023
@dconeybe @andrewheard
Firestore: FIRQueryTests.mm: Add test testBloomFilterShouldCorrectlyE…
16b366d 
…ncodeComplexUnicodeCharacters (#11679)
@firebase firebase locked and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @milaGGL