Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple inequality support #11626

Merged
merged 57 commits into from
Sep 13, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
53eb2f8
initial code
milaGGL Jul 27, 2023
95850ff
add integration tests
milaGGL Jul 27, 2023
14514de
remove single inequality functions
milaGGL Jul 27, 2023
34dd2e9
include set
milaGGL Jul 28, 2023
1141850
update target index matcher
milaGGL Jul 28, 2023
088733b
update code
milaGGL Aug 1, 2023
d114ddc
Merge branch 'master' into mila/multiple-inequality-support
milaGGL Aug 2, 2023
daca229
add implicit order by unit tests
milaGGL Aug 2, 2023
2d5839a
fix typo
milaGGL Aug 2, 2023
ec3ef29
fix typo
milaGGL Aug 2, 2023
8656303
Update query.cc
milaGGL Aug 2, 2023
09adc00
resolve comments
milaGGL Aug 11, 2023
e8b74f0
Merge branch 'master' into mila/multiple-inequality-support
milaGGL Aug 11, 2023
e972262
Update query_test.cc
milaGGL Aug 11, 2023
e5d926e
Update CHANGELOG.md
milaGGL Aug 11, 2023
e0b09a9
add more unit tests for orderby normalization
milaGGL Aug 17, 2023
20e2295
Merge branch 'master' into mila/multiple-inequality-support
milaGGL Aug 17, 2023
a75fdda
Merge branch 'master' into mila/multiple-inequality-support
milaGGL Aug 24, 2023
92a5889
Merge branch 'master' into mila/multiple-inequality-support
milaGGL Aug 29, 2023
bc0759d
CSI compatibility
cherylEnkidu Aug 30, 2023
49898b6
Address feedback get from web review
cherylEnkidu Aug 31, 2023
abe383c
Merge branch 'master' into mila/multiple-inequality-support
milaGGL Aug 31, 2023
a573b6a
resolve comments
milaGGL Aug 31, 2023
ee0046c
Merge branch 'master' into mila/multiple-inequality-support
milaGGL Sep 1, 2023
3caa241
use call_once() to fix the data race on Filter::Rep::memoized_flatten…
dconeybe Sep 5, 2023
6dee927
format
milaGGL Sep 5, 2023
e1709c4
fix broken test by adding the new ThreadSafeMemoizer class
dconeybe Sep 6, 2023
781675d
./scripts/style.sh
dconeybe Sep 6, 2023
b8e9f59
Merge remote-tracking branch 'origin/master' into mila/multiple-inequ…
dconeybe Sep 6, 2023
1a37697
filter.h: add missing #include <mutex>
dconeybe Sep 6, 2023
3395ff9
filter.h: add NOLINT(build/c++11) comment to the line #include <mutex>
dconeybe Sep 6, 2023
2c7a535
filter.cc: fix #include order for lint
dconeybe Sep 6, 2023
e672782
ThreadSafeMemoizer cleanup
dconeybe Sep 6, 2023
3e02a4d
port Denver's code from MIEQ
milaGGL Sep 6, 2023
ad15379
not working
milaGGL Sep 6, 2023
21ad631
fix the compile error
milaGGL Sep 6, 2023
a7fa0e3
make memoized_normalized_order_bys_ use new class
milaGGL Sep 6, 2023
51e08c6
move to util folder
milaGGL Sep 6, 2023
f2fd8f4
format
milaGGL Sep 6, 2023
3ef7044
change the ThreadSafeMemoizer param type
milaGGL Sep 7, 2023
f58c8cf
update test comment
milaGGL Sep 7, 2023
2fe530a
update memoized_target and memoized_aggregate_target
milaGGL Sep 7, 2023
5c614fc
format
milaGGL Sep 7, 2023
3655508
resolve comments
milaGGL Sep 7, 2023
8048d9a
resolve comments
milaGGL Sep 11, 2023
2709afd
Update thread_safe_memoizer.cc
milaGGL Sep 11, 2023
7d5d11b
Update thread_safe_memoizer_test.cc
milaGGL Sep 11, 2023
101b7ee
Update project.pbxproj
milaGGL Sep 11, 2023
6bc389f
resolve comments
milaGGL Sep 11, 2023
9db3707
add "util::"
milaGGL Sep 11, 2023
97189c7
Merge branch 'master' into mila/multiple-inequality-support
milaGGL Sep 12, 2023
1b73d33
Update thread_safe_memoizer_test.cc
milaGGL Sep 13, 2023
4afce21
Merge branch 'mila/thread-safe-memoization' into mila/multiple-inequa…
milaGGL Sep 13, 2023
f68ac37
format
milaGGL Sep 13, 2023
599abe0
Merge branch 'master' into mila/multiple-inequality-support
milaGGL Sep 13, 2023
6ba8402
remove duplicated class ThreadSafeMemoizer
milaGGL Sep 13, 2023
9422d07
remove unused imports
milaGGL Sep 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
resolve comments
  • Loading branch information
milaGGL committed Sep 11, 2023
commit 6bc389fedb8f66995bba972083848a0273b56043
4 changes: 1 addition & 3 deletions Firestore/core/src/core/filter.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
#include "Firestore/core/src/model/model_fwd.h"
#include "Firestore/core/src/util/thread_safe_memoizer.h"

using firebase::firestore::util::ThreadSafeMemoizer;

namespace firebase {
namespace firestore {
namespace core {
Expand Down Expand Up @@ -172,7 +170,7 @@ class Filter {
* (`ThreadSafeMemoizer` is not copyable because of its `std::once_flag`
* member variable, which is not copyable).
*/
mutable std::shared_ptr<ThreadSafeMemoizer<std::vector<FieldFilter>>>
mutable std::shared_ptr<util::ThreadSafeMemoizer<std::vector<FieldFilter>>>
memoized_flattened_filters_;
};

Expand Down
1 change: 1 addition & 0 deletions Firestore/core/src/core/query.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#include "Firestore/core/src/core/target.h"
#include "Firestore/core/src/model/model_fwd.h"
#include "Firestore/core/src/model/resource_path.h"
#include "Firestore/core/src/util/thread_safe_memoizer.h"

namespace firebase {
namespace firestore {
Expand Down
2 changes: 1 addition & 1 deletion Firestore/core/test/unit/util/thread_safe_memoizer_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

#include "Firestore/core/src/util/thread_safe_memoizer.h"

#include <thread>
#include <thread> // NOLINT(build/c++11)
#include "gtest/gtest.h"

namespace firebase {
Expand Down