fixes

firebase · Dec 11, 2024 · 7fa6b95 · 7fa6b95
1 parent b74d065
commit 7fa6b95
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 14 deletions.
diff --git a/FirebasePerformance/Sources/Configurations/FPRRemoteConfigFlags+Private.h b/FirebasePerformance/Sources/Configurations/FPRRemoteConfigFlags+Private.h
@@ -14,7 +14,7 @@
 
 #import "FirebasePerformance/Sources/Configurations/FPRRemoteConfigFlags.h"
 
-#import "FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h"
+@import FirebaseRemoteConfig;
 
 NS_ASSUME_NONNULL_BEGIN
 

diff --git a/FirebasePerformance/Tests/Unit/Configurations/FPRFakeRemoteConfig.h b/FirebasePerformance/Tests/Unit/Configurations/FPRFakeRemoteConfig.h
@@ -14,7 +14,7 @@
 
 #import <Foundation/Foundation.h>
 
-#import "FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h"
+@import FirebaseRemoteConfig;
 
 @import FirebaseRemoteConfig;
 
@@ -38,6 +38,8 @@ NS_ASSUME_NONNULL_BEGIN
 /** @brief Different configurations values that needs to be stored and returned. */
 @property(nonatomic) NSMutableDictionary<NSString *, FIRRemoteConfigValue *> *configValues;
 
+- (instancetype)init;
+
 /**
  * Fake fetch call for fetching configs. Calling this method will just call the completionHandler.
  *

diff --git a/FirebasePerformance/Tests/Unit/Configurations/FPRRemoteConfigFlagsTest.m b/FirebasePerformance/Tests/Unit/Configurations/FPRRemoteConfigFlagsTest.m
@@ -22,6 +22,8 @@
 
 #import "FirebasePerformance/Tests/Unit/Configurations/FPRFakeRemoteConfig.h"
 
+@import FirebaseRemoteConfig;
+
 static NSInteger const kLogSource = 462;  // LogRequest_LogSource_Fireperf
 
 @interface FPRRemoteConfigFlagsTest : XCTestCase

diff --git a/FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h b/FirebaseRemoteConfig/Sources/Private/FIRRemoteConfig_Private.h
@@ -49,18 +49,6 @@ NS_ASSUME_NONNULL_BEGIN
 + (FIRRemoteConfig *)remoteConfigWithFIRNamespace:(NSString *)remoteConfigNamespace
     NS_SWIFT_NAME(remoteConfig(FIRNamespace:));
 
-/// Returns the FIRRemoteConfig instance for your namespace and for the default 3P developer's app.
-/// This singleton object contains the complete set of Remote Config parameter values available to
-/// the app, including the Active Config and Default Config. This object also caches values fetched
-/// from the Remote Config Server until they are copied to the Active Config by calling
-/// activateFetched. When you fetch values from the Remote Config Server using the default Firebase
-/// namespace service, you should use this class method to create a shared instance of the
-/// FIRRemoteConfig object to ensure that your app will function properly with the Remote Config
-/// Server and the Firebase service.
-+ (FIRRemoteConfig *)remoteConfigWithFIRNamespace:(NSString *)remoteConfigNamespace
-                                              app:(FIRApp *)app
-    NS_SWIFT_NAME(remoteConfig(FIRNamespace:app:));
-
 /// Register RolloutsStateSubcriber to FIRRemoteConfig instance
 - (void)addRemoteConfigInteropSubscriber:(id<FIRRolloutsStateSubscriber> _Nonnull)subscriber;
 

diff --git a/FirebaseRemoteConfig/Sources/Public/FirebaseRemoteConfig/FIRRemoteConfig.h b/FirebaseRemoteConfig/Sources/Public/FirebaseRemoteConfig/FIRRemoteConfig.h
@@ -354,5 +354,18 @@ typedef void (^FIRRemoteConfigUpdateCompletion)(FIRRemoteConfigUpdate *_Nullable
                    userDefaults:(nullable NSUserDefaults *)userDefaults
                       analytics:(nullable id<FIRAnalyticsInterop>)analytics;
 
+/// Firebase INTERNAL use only!
+/// Returns the FIRRemoteConfig instance for your namespace and for the default 3P developer's app.
+/// This singleton object contains the complete set of Remote Config parameter values available to
+/// the app, including the Active Config and Default Config. This object also caches values fetched
+/// from the Remote Config Server until they are copied to the Active Config by calling
+/// activateFetched. When you fetch values from the Remote Config Server using the default Firebase
+/// namespace service, you should use this class method to create a shared instance of the
+/// FIRRemoteConfig object to ensure that your app will function properly with the Remote Config
+/// Server and the Firebase service.
++ (FIRRemoteConfig *)remoteConfigWithFIRNamespace:(NSString *)remoteConfigNamespace
+                                              app:(FIRApp *)app
+    NS_SWIFT_NAME(remoteConfig(FIRNamespace:app:));
+
 @end
 NS_ASSUME_NONNULL_END