review

firebase · Dec 16, 2024 · 534ea5c · 534ea5c
1 parent e4a895c
commit 534ea5c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/FirebaseRemoteConfig/Sources/Public/FirebaseRemoteConfig/FIRRemoteConfig.h b/FirebaseRemoteConfig/Sources/Public/FirebaseRemoteConfig/FIRRemoteConfig.h
@@ -356,7 +356,7 @@ typedef void (^FIRRemoteConfigUpdateCompletion)(FIRRemoteConfigUpdate *_Nullable
                    userDefaults:(nullable NSUserDefaults *)userDefaults
                       analytics:(nullable id<FIRAnalyticsInterop>)analytics;
 
-/// Register RolloutsStateSubcriber to FIRRemoteConfig instance
+/// Register `FIRRolloutsStateSubscriber` to `FIRRemoteConfig` instance
 - (void)addRemoteConfigInteropSubscriber:(id<FIRRolloutsStateSubscriber> _Nonnull)subscriber;
 
 @end

diff --git a/FirebaseRemoteConfig/SwiftNew/RemoteConfigComponent.swift b/FirebaseRemoteConfig/SwiftNew/RemoteConfigComponent.swift
@@ -65,6 +65,7 @@ extension RemoteConfigComponent: RemoteConfigProvider {
       return nil
     }
 
+    // Validate the required information is available.
     let errorPropertyName = if app.options.googleAppID.isEmpty {
       "googleAppID"
     } else if app.options.gcmSenderID.isEmpty {
@@ -74,13 +75,9 @@ extension RemoteConfigComponent: RemoteConfigProvider {
     } else { nil as String? }
 
     if let errorPropertyName {
-      NSException.raise(
-        NSExceptionName("com.firebase.config"),
-        format: "Firebase Remote Config is missing the required %@ property from the " +
-          "configured FirebaseApp and will not be able to function properly. " +
-          "Please fix this issue to ensure that Firebase is correctly configured.",
-        arguments: getVaList([errorPropertyName])
-      )
+      fatalError("Firebase Remote Config is missing the required \(errorPropertyName) property from the " +
+        "configured FirebaseApp and will not be able to function properly. " +
+        "Please fix this issue to ensure that Firebase is correctly configured.")
     }
 
     instancesLock.lock()