upgrade to AGP7 #1979
Merged
upgrade to AGP7 #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
reviewed
Jul 22, 2021
samtstern
reviewed
Jul 22, 2021
database/src/main/java/com/firebase/ui/database/FirebaseRecyclerAdapter.java
Show resolved
Hide resolved
|
@rosariopfernandes you are a legend! I can't believe you got this all working so quickly. |
|
@samtstern I was just about to push that, OMG 😆 |
|
@rosariopfernandes you were right about July 28th! 7.0 is out and I just updated your branch (I wanted to be faster than you for once in my life haha) |
|
@samtstern You did it, I'm impressed. I bow down to you 😆 |
|
I'll release 8.0 tomorrow! |
|
I was updating rtdb to use Paging 3, but there were some runtime errors, I
think I got something wrong.
I'll send a PR with the changes tomorrow so we can have a look at it
together.
Update: I fixed the runtime errors and submitted a PR. See #1983
…On Wed, Jul 28, 2021, 19:29 Sam Stern ***@***.***> wrote:
I'll release 8.0 tomorrow!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1979 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD75OBT54PQ36U6U3DMBJA3T2A5AZANCNFSM5ASGWDMQ>
.
|
|
@rosariopfernandes oh wow I almost forgot about that change! Thanks for the reminder. No rush on that PR, 8.0 will go out when that's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1966
This PR should:
UnusedIdsandUnusedResourceslint errors.UnusedIdslint error thrown in theappmodule - seems like AGP7 can't yet detect when an id is being used by ViewBinding.MediaCapabilitieslint error thrown in theappmodule - I couldn't figure out where this error is coming from, but I'm guessing Glide is responsible for it.