-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added setLockOrientation for activities #1839
Merged
samtstern
merged 14 commits into
firebase:version-6.4.0-dev
from
laurentiu-git:lockOrientation
Sep 29, 2020
Merged
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
291d275
Added setLockOrientation for activities
laurentiu-git 27459cc
Merge branch 'version-6.4.0-dev' into lockOrientation
laurentiu-git 65e02fc
Changed the implementation as requested.
laurentiu-git c8b1dc3
Merge remote-tracking branch 'origin/lockOrientation' into lockOrient…
laurentiu-git 264e692
Added setLockOrientation for activities
laurentiu-git 68c8b28
Changed the implementation as requested.
laurentiu-git c1f6f80
Merge branch 'lockOrientation' of https://github.com/laurentiu-git/Fi…
laurentiu-git 06fd9ac
Changed the implementation as requested.
laurentiu-git 043ccc4
Delete AuthMethodPickerActivity.java
laurentiu-git 2a6127d
Changed the implementation as requested.
laurentiu-git 3793cf1
Merge remote-tracking branch 'origin/lockOrientation' into lockOrient…
laurentiu-git 82372d3
Changed the implementation as requested.
laurentiu-git 4a9043b
Changed the implementation as requested.
laurentiu-git 49de6fb
removed change
laurentiu-git File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
auth/src/main/java/com/firebase/ui/auth/ui/HelperActivityBase.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,8 +14,10 @@ | |
|
||
package com.firebase.ui.auth.ui.idp; | ||
|
||
import android.annotation.SuppressLint; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are no changes in this file anymore besides these two imports and some whitespace, so maybe we can revert the whole file? |
||
import android.content.Context; | ||
import android.content.Intent; | ||
import android.content.pm.ActivityInfo; | ||
import android.os.Bundle; | ||
import android.text.TextUtils; | ||
import android.view.View; | ||
|
@@ -101,7 +103,6 @@ protected void onCreate(@Nullable Bundle savedInstanceState) { | |
mHandler = ViewModelProviders.of(this).get(SocialProviderResponseHandler.class); | ||
mHandler.init(params); | ||
|
||
|
||
mProviders = new ArrayList<>(); | ||
if (customLayout != null) { | ||
setContentView(customLayout.getMainLayout()); | ||
|
@@ -270,6 +271,8 @@ private String providerOrEmailLinkProvider(@NonNull String providerId) { | |
return providerId; | ||
} | ||
|
||
|
||
|
||
private void handleSignInOperation(final IdpConfig idpConfig, View view) { | ||
ViewModelProvider supplier = ViewModelProviders.of(this); | ||
final String providerId = idpConfig.getProviderId(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually need this
@SuppressLint
anymore? If so can we be more specific thanall
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without
@SuppressLint
when running gradlew check it gives the following error and I don't know how suppress it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So then could it be
@SuppressLint("SourceLockedOrientationActivity")
?