Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CountryListSpinner does not set the selected CountryInfo #2005

Closed
c2call opened this issue Oct 14, 2021 · 5 comments
Closed

CountryListSpinner does not set the selected CountryInfo #2005

c2call opened this issue Oct 14, 2021 · 5 comments
Assignees

Comments

@c2call
Copy link

c2call commented Oct 14, 2021

Firebase Auth-UI sign-in with phone number has an issue as the CountryListSpinner does not provider the actual selected CountryInfo via method getSelectedCountryInfo().
I've checked the code an there is a small change required:

    mListPopupWindow.setOnItemClickListener(new AdapterView.OnItemClickListener() {
        @Override
        public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
            CountryInfo info = mCountryListAdapter.getItem(position);
            if (info != null) {
                mSelectedCountryInfo = info; // This needs to be added in order to set the selected country info 
                setText(info.toShortString());
            }

            onUnfocus();
        }
    });

Please check, "mSelectedCountryInfo = info;" needs to be set as commented above.
Please update, as phone number authentication is not working in version 8.0.0 due to missing country code.

@mikehardy
Copy link

This looks like it would be a great PR - you can just hit the edit button on the top right of that file here on github and propose it ?

@EricAlvarez292
Copy link

            mSelectedCountryInfo = info; // This needs to be added in order to set the selected country info 

when can we expect this fix push to latest release?

underscore200 added a commit to underscore200/FirebaseUI-Android that referenced this issue Jan 3, 2022
@Surendar7
Copy link

Hi, When will the next version be released with this fix?

@DzmitryKavaliou
Copy link

Guys, it's terrible. You have a critical issue for several month. You have more than 10 people who is waiting for a fix. Finally, you have this fix. Why you don't just release a new version with a fix? Does google pay for development of this library? If it does it definitely should not!

@sam-gc
Copy link
Contributor

sam-gc commented Mar 30, 2022

The fix will be available in version 8.0.1 which should be available shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants