fix(@angular/cli): work around npm peerdep issue

NPM hoists dependencies with peerDeps of their own, leading to unmet peer dependencies. This workaround should be safe for now since the only two packages that depend on `[email protected]` are `webpack` and `schema-utils`. See angular#9691 (comment) and npm/npm#19877 for more information. Fix angular#9691.
filipesilva · Feb 21, 2018 · 72a057a · 72a057a
1 parent 77d2cd3
commit 72a057a
Show file tree

Hide file tree

Showing 4 changed files with 72 additions and 11 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -46,6 +46,7 @@
     "@angular-devkit/schematics": "0.3.1",
     "@schematics/angular": "0.3.1",
     "@schematics/package-update": "0.3.1",
+    "ajv": "^6.1.1",
     "autoprefixer": "^7.2.3",
     "cache-loader": "^1.2.0",
     "chalk": "~2.2.0",

diff --git a/packages/@angular/cli/lib/cli/index.ts b/packages/@angular/cli/lib/cli/index.ts
@@ -1,3 +1,9 @@
+// We don't actually require AJV, but there is a bug with NPM and peer dependencies that is
+// whose workaround is to depend on AJV.
+// See https://github.com/angular/angular-cli/issues/9691#issuecomment-367322703 for details.
+// We need to add a require here to satisfy the dependency checker.
+// require('ajv');
+
 import * as path from 'path';
 
 const cli = require('../../ember-cli/lib/cli');

diff --git a/packages/@angular/cli/package.json b/packages/@angular/cli/package.json
@@ -34,6 +34,7 @@
     "@ngtools/webpack": "1.10.0-rc.0",
     "@schematics/angular": "0.3.1",
     "@schematics/package-update": "0.3.1",
+    "ajv": "^6.1.1",
     "autoprefixer": "^7.2.3",
     "cache-loader": "^1.2.0",
     "chalk": "~2.2.0",