Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Update miner tests to use NV=3 Window PoSt fee reductions #1192

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

anorth
Copy link
Member

@anorth anorth commented Sep 26, 2020

More validation for the changes from #1181 (FIP-0002). I have already done this on master but wanted to check this has the same behaviour. There are many fewer tests on this branch, so it's not a big change.

@anorth anorth requested a review from acruikshank September 26, 2020 05:02
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2020

Codecov Report

Merging #1192 into release/v0.9 will decrease coverage by 0.4%.
The diff coverage is 29.2%.

@@              Coverage Diff               @@
##           release/v0.9   #1192     +/-   ##
==============================================
- Coverage          73.1%   72.7%   -0.5%     
==============================================
  Files                51      52      +1     
  Lines              5470    5511     +41     
==============================================
+ Hits               4004    4009      +5     
- Misses              878     923     +45     
+ Partials            588     579      -9     

Copy link
Contributor

@acruikshank acruikshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -3109,7 +3059,7 @@ type cronConfig struct {
expectedEnrollment abi.ChainEpoch
vestingPledgeDelta abi.TokenAmount // nolint:structcheck,unused
detectedFaultsPowerDelta *miner.PowerPair
detectedFaultsPenalty abi.TokenAmount
//detectedFaultsPenalty abi.TokenAmount
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

@anorth anorth merged commit a6848b2 into release/v0.9 Sep 30, 2020
@anorth anorth deleted the anorth/09wposttest branch September 30, 2020 01:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants