polish: add Equals method to MinerInfo shim #4604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
|
this might cause problems if these structs ever get roundtripped over json. The cid field would get cleared, and any two miner infos would be 'equal' |
|
Ahh you are right, good catch. Edit: On second thought it will probably be easiest to mimic the |
frrist
force-pushed
the
frrist/miner-shim-info-equal
branch
from
3d0e401 to
0d38405
Compare
Stebalien
approved these changes
Oct 26, 2020
|
The code added here currently isn't called anywhere in lotus. The CI failures appear to be flaky tests. |
whyrusleeping
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Easier comparison of MinerInfo structs
Implementation
Perform a comparison by casting the interface to its underlying structure and comparing Info cids similar to what is done in
DeadlinesChanged.