Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated msig inspect: #4533

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Updated msig inspect: #4533

merged 1 commit into from
Oct 26, 2020

Conversation

jennijuju
Copy link
Member

  • Show account address of signers
  • When a message receiver is a new account, do not lookup method name.

sample updated output

[email protected]:~/filecoin/lotusl msig inspect  t01009
Balance: 0 FIL
Spendable: 0 FIL
Threshold: 2 / 3
Signers:
ID      Address
t01001  t1m2o2btagagiovb6tjhfjailocqrvwzqilp4ib3y
t0100   t3whxa3ume3jrvmvnksuhofioehbowf3q6ma7fq5stytjl4vbebqzeouwsoz22e7nwh3ahjboiq3753zwhavya
t01005  t12hefpm6ov7jocmz3aqoc66lyxsl23odngq3raiy
Transactions:  1
ID      State    Approvals  To                                         Value   Method                          Params
0       pending  1          t1mg6ywcbkj4lupnkgskipw3dpwr22eujkwulr2ji  0 FIL   new address, unknown method(3)  a703

Resolves #4369

@jennijuju jennijuju requested a review from arajasek October 22, 2020 08:10
magik6k
magik6k reviewed Oct 22, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 small issue

cli/multisig.go Show resolved Hide resolved
whyrusleeping
whyrusleeping reviewed Oct 23, 2020
View reviewed changes
cli/multisig.go Outdated Show resolved Hide resolved
@jennijuju
Updated msig inspect:
f05b03f 
- Show account address of signer if the id address is corresponding to  an account address.
- When a message receiver is a new account, do not lookup method name.
@magik6k magik6k merged commit 09f1d00 into master Oct 26, 2020
@magik6k magik6k deleted the msig-inspect-jen branch October 26, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@arajasek arajasek Awaiting requested review from arajasek

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show account address in msig inspect
3 participants
@jennijuju @whyrusleeping @magik6k