Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize mining code #4379

Merged
merged 1 commit into from
Oct 22, 2020
Merged

optimize mining code #4379

merged 1 commit into from
Oct 22, 2020

Conversation

zgfzgf
Copy link
Contributor

@zgfzgf zgfzgf commented Oct 14, 2020

lotus/chain/stmgr/utils.go

Line 78 in 9c6ee80

return vm.ResolveToKeyAddr(state, sm.cs.Store(ctx), info.Worker)

delete duplicate code

Stebalien
Stebalien approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct. WalletSign resolves the address internally.

@magik6k magik6k merged commit 05b459e into filecoin-project:master Oct 22, 2020
@zgfzgf zgfzgf deleted the feat-mining branch December 4, 2020 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Stebalien Stebalien Stebalien approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zgfzgf @Stebalien @magik6k