MpoolPushUntrusted API for gateway #3915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mp.curTsLk.Unlock() | ||
|
|
||
| mp.lk.Lock() | ||
| if err := mp.addLocal(m, msgb); err != nil { |
There was a problem hiding this comment.
we don't still want to do addLocal do we?
There was a problem hiding this comment.
Well, I am ambivalent about this; if we don't the messages will be transient, ie they might disappear in the next prune.
We can certainly remove the addLocal incantation.
magik6k
reviewed
Sep 23, 2020
| @@ -55,6 +55,7 @@ var baseFeeLowerBoundFactor = types.NewInt(10) | |||
| var baseFeeLowerBoundFactorConservative = types.NewInt(100) | |||
|
|
|||
| var MaxActorPendingMessages = 1000 | |||
| var MaxUntrustedActorPendingMessages = 10 | |||
There was a problem hiding this comment.
- Do we use that for messages coming from the messages pubsub?
- If yes, that's likely way too low, many bigger miners have many more messages that that per tipset
There was a problem hiding this comment.
no, we only use it for the gateway -- messages coming from pubsub use Add.
dirkmc
reviewed
Sep 23, 2020
magik6k
approved these changes
Oct 2, 2020
|
@vyzo Please tell me how to quickly access lotus gateway, such as client.NewGatewayRPC and GetGatewayAPI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an mpool API for the gateway to push messages, PushUntrusted.
The difference with Push is that strict checks are enabled and in addition there are no nonce gaps
allowed and the number of pending messages for each actor is severely limited.
Hopefully this will make the gateway usable without much fear of spam.