storage: split window PoST submission into multiple messages #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
commented
Sep 9, 2020
storage/wdpost_run.go
Outdated
| } | ||
|
|
||
| var sinfos []proof.SectorInfo |
There was a problem hiding this comment.
The logic here should be the same, the indentation just makes it hard to compare (use diff settings to hide whitespace)
|
Note: TestAPIRPC/testMiningReal failed in CI but works for me locally |
Stebalien
approved these changes
Sep 9, 2020
Stebalien
approved these changes
Sep 10, 2020
dirkmc
force-pushed
the
feat/batch-window-PoST
branch
4 times, most recently
from
5df2939 to
85ee7ff
Compare
|
@Stebalien sorry I had to rebase again after #3710 was merged, please take one more look |
Stebalien
approved these changes
Sep 14, 2020
| for batchIdx, batch := range partitionBatches { | ||
| batchPartitionStartIdx := 0 | ||
| for _, batch := range partitionBatches[:batchIdx] { | ||
| batchPartitionStartIdx += len(batch) |
There was a problem hiding this comment.
Why not just keep a running count?
dirkmc
force-pushed
the
feat/batch-window-PoST
branch
from
85ee7ff to
86ec8eb
Compare
dirkmc
force-pushed
the
feat/batch-window-PoST
branch
from
86ec8eb to
db998e9
Compare
magik6k
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3332