Update to specs actors v0.9.6 #3603
Conversation
arajasek
commented
Sep 7, 2020
•
arajasek
commented
- Largely a "follow the pattern" PR
- This introduces the go-state-types
- Updates go-fil-markets to include non-blocking retrieval
| @@ -300,7 +303,7 @@ type FullNode interface { | |||
| // StateMinerSectors returns info about the given miner's sectors. If the filter bitfield is nil, all sectors are included. | |||
| // If the filterOut boolean is set to true, any sectors in the filter are excluded. | |||
| // If false, only those sectors in the filter are included. | |||
| StateMinerSectors(context.Context, address.Address, *abi.BitField, bool, types.TipSetKey) ([]*ChainSectorInfo, error) | |||
| StateMinerSectors(context.Context, address.Address, *bitfield.BitField, bool, types.TipSetKey) ([]*ChainSectorInfo, error) | |||
There was a problem hiding this comment.
Because its an alias there's no difference but you if for some reason you wanted to keep using the specs-actors bitfield alias you can import it from specs-actors/actors/util here and everywhere else making this change.
There was a problem hiding this comment.
Eeeh, I would've done that if I'd realised it earlier, but I don't think it's worth undoing?
arajasek
force-pushed
the
asr/specs-for-0.6.0
branch
from
816e58c to
529002c
Compare
| @@ -341,7 +341,7 @@ func (rt *Runtime) Send(to address.Address, method abi.MethodNum, m vmr.CBORMars | |||
| if m != nil { | |||
| buf := new(bytes.Buffer) | |||
| if err := m.MarshalCBOR(buf); err != nil { | |||
| rt.Abortf(exitcode.SysErrInvalidParameters, "failed to marshal input parameters: %s", err) | |||
| rt.Abortf(exitcode.ErrSerialization, "failed to marshal input parameters: %s", err) | |||
There was a problem hiding this comment.
This is a consensus-affecting change. It should be behind a network version check.
There was a problem hiding this comment.
@anorth This one "sneaked" in -- it doesn't break consensus pre-upgrade, (and won't break things moving forward).
There was a problem hiding this comment.
How does it not break consensus? It'll change the error codes (or do those not go on chain?).
