Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use errors.New to replace fmt.Errorf with no parameters #12777

Closed
wants to merge 1 commit into from

Conversation

RiceChuan
Copy link

use errors.New to replace fmt.Errorf with no parameters

@rjan90
Copy link
Contributor

rjan90 commented Dec 12, 2024

Hey @RiceChuan! Thanks for the contribution - I think it is worth highlighting this comment made by Rod on similar changes earlier in the week in this PR: #12769 (review)

As nice as this is, it's not a hard standard that we enforce in this codebase, in fact we use xerrors more than errors, but even that's not consistent except where we're wrapping errors.

This PR just opens the door to a larger change-set that I don't think I want to encourage as small PRs because it'll just be highlighting the inconsistency rather than solving it:

As there are no other changes in this PR then the errors.New() changes, I will close this PR.

@rjan90 rjan90 closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

2 participants