-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sync): do not allow to expand checkpointed tipsets #12747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves a bug in sync by preventing checkpoint expansion. Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
kubuxu/sync/chck-expansion
branch
from
December 2, 2024 18:28
6abc81c
to
6ac3f01
Compare
Stebalien
reviewed
Dec 2, 2024
@rvagg : it came up during 2024-12-02 F3 sync that it would be good if you're able to review this as this is one of the blockers for a 1.32.0 RC (release issue coming...) |
rvagg
reviewed
Dec 3, 2024
Signed-off-by: Jakub Sztandera <[email protected]>
masih
approved these changes
Dec 3, 2024
Stebalien
reviewed
Dec 3, 2024
Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
kubuxu/sync/chck-expansion
branch
from
December 3, 2024 23:32
2943ab5
to
f31aac4
Compare
Signed-off-by: Jakub Sztandera <[email protected]>
Stebalien
approved these changes
Dec 4, 2024
Signed-off-by: Jakub Sztandera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a bug in sync by preventing checkpoint expansion.