Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api: market pending proposal API/CLI #12724

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Nov 25, 2024

Related Issues

Proposed Changes

  • Add a StateMarketProposalPending API, lotus state market proposal-pending cli, and related api in chain/actors/builtin

Additional Info

I needed a way to check this, and as it turns out there were zero other ways to get reasonably convenient access to the pending deal set, so new there is.

Checklist

Before you mark the PR ready for review, please make sure that:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magik6k magik6k changed the title feat: Market pending proposal API/CLI feat: api: Market pending proposal API/CLI Nov 25, 2024
@github-actions github-actions bot dismissed their stale review November 25, 2024 16:23

PR title now matches the required format.

@magik6k magik6k force-pushed the feat/pending-proposal-api branch from c84eeac to b0a6b97 Compare November 25, 2024 16:25
@magik6k magik6k force-pushed the feat/pending-proposal-api branch from b0a6b97 to 4510d00 Compare November 25, 2024 16:26
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough

@rvagg
Copy link
Member

rvagg commented Nov 28, 2024

@magik6k just needs a make docsgen-cli and it's good to go

@rvagg rvagg changed the title feat: api: Market pending proposal API/CLI feat: api: market pending proposal API/CLI Nov 28, 2024
@magik6k
Copy link
Contributor Author

magik6k commented Nov 28, 2024

Done

@rvagg rvagg merged commit 64736ea into master Nov 29, 2024
83 checks passed
@rvagg rvagg deleted the feat/pending-proposal-api branch November 29, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

3 participants