Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(miner): use the "from" address as the sender if it is set #12662

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix(miner): use the "from" address as the sender if it is set #12662

merged 1 commit into from
Oct 31, 2024

Conversation

asamuj
Copy link
Contributor

@asamuj asamuj commented Oct 31, 2024 •
edited
Loading

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

@rvagg rvagg requested a review from LexLuthr October 31, 2024 05:19
rvagg
rvagg approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, will let @LexLuthr 👍 first though

LexLuthr
LexLuthr approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't caught till now as usually owner is sender.

@LexLuthr LexLuthr added the skip/changelog This change does not require CHANGELOG.md update label Oct 31, 2024
@rvagg rvagg merged commit 04d31d3 into filecoin-project:master Oct 31, 2024
92 of 109 checks passed
@rvagg rvagg mentioned this pull request Nov 29, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LexLuthr LexLuthr LexLuthr approved these changes

@rvagg rvagg rvagg approved these changes

Assignees
No one assigned
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
FilOz
Status: ☑️ Done (Archive)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asamuj @rvagg @LexLuthr