test(eth): fix bloom filter test flake #12643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mask changes based on the address of the deployed actor. In this test, this address is not constant because we don't deploy with CREATE2. Instead of checking bits and then counting the number of bits, just re-create the expected bloom filter and verify that it's correct. NOTE: the original test was broken because it expected 6 bits: 3 from the topic, 3 from the address. But bloom filters are probabilistic and we could have anywhere from 3-6 bits depending on how many collisions we get.
8 tasks
Stebalien
added
the
skip/changelog
|
CI (the eth conformance test, specifically) is going to fail because #12642 |
masih
approved these changes
Oct 26, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Fix the flaky bloom filter test.
The mask changes based on the address of the deployed actor. In this test, this address is not constant because we don't deploy with CREATE2.
Instead of checking bits and then counting the number of bits, just re-create the expected bloom filter and verify that it's correct.
NOTE: the original test was broken because it expected 6 bits: 3 from the topic, 3 from the address. But bloom filters are probabilistic and we could have anywhere from 3-6 bits depending on how many collisions we get.
Checklist
Before you mark the PR ready for review, please make sure that: