Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix participation loop so the miner re-joins if lotus restarts #719

Closed
Kubuxu opened this issue Oct 24, 2024 · 1 comment
Closed

Fix participation loop so the miner re-joins if lotus restarts #719

Kubuxu opened this issue Oct 24, 2024 · 1 comment
Assignees
@Stebalien

Comments

@Kubuxu
Copy link
Contributor

Kubuxu commented Oct 24, 2024

Currently, if the lotus node restarts and the F3 network does not make progress beyond the leased instance, the miner won't participate.
@github-project-automation github-project-automation bot moved this to Todo in F3 Oct 24, 2024
@masih masih mentioned this issue Oct 24, 2024
Merged
21 tasks
@Stebalien Stebalien mentioned this issue Oct 24, 2024
Closed
@Stebalien
Copy link
Member

Stebalien commented Oct 25, 2024 •
edited
Loading

Ok, I've tried a few fixes here and I think the right answer is to:

  1. Remove the calls to F3GetManifest and F3GetProgress.
  2. Add a RecheckAt field to the lease telling the miner when to check the lease. This is optional, but it means we don't need to grab the manifest to compute when we should check again. Alternatively, we can grab the manifest once every time the network changes? yes, let's just re-grab the manifest.
  3. At that time, call F3Participate again.
  4. The lease returned by F3Participate specifies the current instance along with the remaining number of instances for which the lease is valid. If this remaining number is less than half the initial lease term, the miner gets a new lease.

Stebalien added a commit to filecoin-project/lotus that referenced this issue Oct 25, 2024
@Stebalien
fix(f3): poll the lease by repeatedly participating instead of checki…
1ae4fa7 
…ng progress

Previously, the flow was:

1. Get ticket.
2. Participate.
3. Repeatedly poll progress.

The new flow is:

1. Get ticket.
2. Repeatedly participate, using the returned lease as an indicator of progress.

That way, if the lotus node reboots we'll eventually re-tell them about
the lease.

fixes filecoin-project/go-f3#719
@Stebalien Stebalien mentioned this issue Oct 25, 2024
Merged
8 tasks
@masih masih moved this from Todo to In progress in F3 Oct 25, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in F3 Oct 25, 2024
rjan90 pushed a commit to filecoin-project/lotus that referenced this issue Oct 28, 2024
@Stebalien @rjan90
fix(f3): poll the lease by repeatedly participating instead of checki…
58fc4f6 
…ng progress (#12640)

Previously, the flow was:

1. Get ticket.
2. Participate.
3. Repeatedly poll progress.

The new flow is:

1. Get ticket.
2. Repeatedly participate, using the returned lease as an indicator of progress.

That way, if the lotus node reboots we'll eventually re-tell them about
the lease.

fixes filecoin-project/go-f3#719
rjan90 pushed a commit to filecoin-project/lotus that referenced this issue Oct 28, 2024
@Stebalien @rjan90
fix(f3): poll the lease by repeatedly participating instead of checki…
248a624 
…ng progress (#12640)

Previously, the flow was:

1. Get ticket.
2. Participate.
3. Repeatedly poll progress.

The new flow is:

1. Get ticket.
2. Repeatedly participate, using the returned lease as an indicator of progress.

That way, if the lotus node reboots we'll eventually re-tell them about
the lease.

fixes filecoin-project/go-f3#719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
F3
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @Kubuxu