-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SupraSeal #69
Merged
Merged
SupraSeal #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
feat/supra_seal
branch
13 times, most recently
from
July 7, 2024 08:00
a649566
to
30f7ed0
Compare
magik6k
force-pushed
the
feat/snap
branch
6 times, most recently
from
July 16, 2024 14:04
10ecd79
to
aff115d
Compare
magik6k
force-pushed
the
feat/supra_seal
branch
5 times, most recently
from
July 31, 2024 11:53
25c2e6e
to
2ee19eb
Compare
magik6k
commented
Jul 31, 2024
snadrus
requested changes
Aug 3, 2024
Lets document this as Batch Sealing Beta in documentation/en/batchsealing.md since we hope to 1. modernize deps, 2. get rid of spdk 3. avoid needing Rust bin formats. |
magik6k
force-pushed
the
feat/supra_seal
branch
from
August 6, 2024 15:24
9fcdcba
to
325cab5
Compare
magik6k
force-pushed
the
feat/supra_seal
branch
from
August 7, 2024 08:08
d1688ad
to
38bffb6
Compare
snadrus
reviewed
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put your PR doc info into documentation/en/batchsealing.md
so that doc is already updated in this PR?
magik6k
force-pushed
the
feat/supra_seal
branch
from
August 8, 2024 17:22
cd0d59f
to
6daa769
Compare
magik6k
force-pushed
the
feat/supra_seal
branch
from
August 8, 2024 17:41
931b4c6
to
2f66ddf
Compare
magik6k
force-pushed
the
feat/supra_seal
branch
from
August 8, 2024 18:32
62ef0ff
to
68af4e6
Compare
snadrus
reviewed
Aug 8, 2024
snadrus
requested changes
Aug 8, 2024
snadrus
requested changes
Aug 9, 2024
snadrus
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curio seal batch-checklist
command checking readiness for batch sealingBuild:
Usage
make curio
for binaries without batch sealer support - it should be fine to use batch sealer binaries everywhere tho.). Usemake batch
to build batch-capable curio on batch-sealer nodescurio calc batch-cpu
. This will tell you what batch sizes the installed CPU can support. Note that in case of two-CPU systems performance might suffer significantly due to the CPU interconnect bottleneck. This wasn't tested yet so performance is unknown.batch-machine1
3.1. Set
Subsystems.EnableBatchSeal
to true3.2. Set
Seal.LayerNVMEDevices
to a list of nvme devices for layer storage3.3. IF your CPU is older, set
Seal.SingleHasherPerThread
to true - this is needed for Zen2 or OLDER (Epyc 7xx2)Subsystems.SealSDRMinTasks
on one of the layers used by single-sector SDR sealers to a value larger than batch size - this is so that the non-batch sealers don't steal work before enough accumulates to start a batchStorage Recs:
You need 2 sets of nvme drives
Random unsorted notes:
gpu fan speed on headless systems
xorg.conf:
Hugepages must be configured (1g, min 36 pages for 32G sector sealing)