Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: batching #343

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: batching #343

wants to merge 6 commits into from

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Dec 9, 2024

No description provided.

magik6k
magik6k reviewed Dec 10, 2024
View reviewed changes
deps/config/types.go Outdated Show resolved Hide resolved
magik6k
magik6k reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, still looking at aggregation

harmony/harmonydb/sql/20241210-sdr-batching.sql Show resolved Hide resolved
tasks/seal/poller_commit_msg.go Show resolved Hide resolved
tasks/seal/task_submit_commit.go Outdated Show resolved Hide resolved
@LexLuthr LexLuthr requested a review from magik6k December 12, 2024 17:32
magik6k
magik6k reviewed Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small comments, other that that I'll probably put this on my setup for testing in a bit

tasks/seal/poller_commit_msg.go Outdated Show resolved Hide resolved
tasks/seal/task_submit_commit.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LexLuthr @magik6k