Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unsealed sector for synthetic PoRep #295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: unsealed sector for synthetic PoRep #295

wants to merge 1 commit into from

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Oct 23, 2024 •
edited
Loading

This PR makes the following changes:

  1. Generating Unsealed is now a separate function called GenerateUnsealedSector()
  2. This function is called by Synthetic Task if required and generating the unsealed sector before removing the cache.
  3. Finalize calls generating unseal only if proof types is not synthetic.
  4. Acquiring sector from Storage is still done by the primary function in each task as passed to GenerateUnsealedSector().
  • Test in calibnet

@LexLuthr LexLuthr requested review from magik6k and snadrus October 23, 2024 13:01
magik6k
magik6k reviewed Oct 23, 2024
View reviewed changes
lib/ffi/sdr_funcs.go
if err = sb.GenerateUnsealedSector(ctx, sector, fspaths, pathIDs, keepUnsealed); err != nil {
return xerrors.Errorf("generating unsealed sector: %w", err)
}

if err = ffi.ClearCache(uint64(ssize), fspaths.Cache); err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure ClearCache will work when tree-d is not present? I imagine it should have no issues, but I'm actually not 100% certain, so we should test this first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good idea. @Reiers Can we test this on calibnet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k left review comments

@snadrus snadrus Awaiting requested review from snadrus

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LexLuthr @magik6k