Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not return early from message watcher #276

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix: do not return early from message watcher #276

merged 1 commit into from
Oct 14, 2024

Conversation

LexLuthr
Copy link
Contributor

Early return can choke the cluster if first message results in the error. We should should log the error and try the next one.

@LexLuthr LexLuthr requested a review from magik6k October 14, 2024 11:39
magik6k
magik6k approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gee yes that's very broken

@LexLuthr LexLuthr merged commit a488679 into main Oct 14, 2024
28 checks passed
@LexLuthr LexLuthr deleted the fix/watcher branch October 14, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LexLuthr @magik6k