Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh #202

Merged
merged 1 commit into from
Sep 19, 2024
Merged

zh #202

merged 1 commit into from
Sep 19, 2024

Conversation

snadrus
Copy link
Contributor

@snadrus snadrus commented Sep 18, 2024

Make Curio more approachable and friendly for speakers of Simplified Mandarin (Chinese).

Docs:
zh category added
Labels have EACH of English and SImplified Mandarin. This allows:

  • English documentation subpage links with en --> zh changed should work.
  • When portions of pages change, it will be easy to find that portion in the translated pages for updating.

Coming soon:

  • Docs diagrams
  • CLI usage & descriptions
  • Verifying this auto-translation is sane.

@snadrus snadrus requested a review from LexLuthr September 18, 2024 19:53
@snadrus
Copy link
Contributor Author

snadrus commented Sep 18, 2024

@LexLuthr Do you have SVGs of the diagram images?
GPT's PNG --> SVG capabilities were a good start, but sub-par. It's direct translation was concept-art.

@LexLuthr
Copy link
Contributor

https://link.excalidraw.com/l/1mkFR98ejh4/24Tsl7OMGav is for the pipeline. You can download whatever format you require. We should probably get some native speaker to review this once.

@strahe
Copy link
Contributor

strahe commented Sep 19, 2024

Awesome, this would be very helpful.

Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest merging this PR as is. Even if merged, this won't create the new docs in Gitbook. I still need to attach that part to the Gitbook side and start the sync for "zh" version.
We can fix remaining things in a follow up PR and then publish the "zh" version.

@snadrus
Copy link
Contributor Author

snadrus commented Sep 19, 2024

I've got a biggish addition to this pr that fixes the cli translations. It's a TODO. We also could use the diagrams translated.

@snadrus
Copy link
Contributor Author

snadrus commented Sep 19, 2024

OK I will merge. The holes it has are nothing compared to it missing entirely.

@snadrus snadrus marked this pull request as ready for review September 19, 2024 14:34
@snadrus snadrus merged commit ecdbcc2 into main Sep 19, 2024
8 of 10 checks passed
@snadrus snadrus deleted the feat/zh branch September 19, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants