Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid sp in the sector list page #152

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

strahe
Copy link
Contributor

@strahe strahe commented Aug 15, 2024

image

image

@LexLuthr
Copy link
Contributor

@strahe Make sure to get screenshots of this table. Especially the right most part. Since we are replacing a column, I don't think render should be affected but I would like to be sure. Also, this change will break terminateSectors method as the input for that method will change. You need do the following:

  1. Update the index.html to use the updated column name "MinerAddress" as part of terminate & delete
  2. Update terminateSectors to set address string as input and handle from there

@strahe
Copy link
Contributor Author

strahe commented Aug 15, 2024

image

image

image

Terminate works correctly.

web/api/sector/sector.go Outdated Show resolved Hide resolved
@LexLuthr LexLuthr merged commit 1217489 into filecoin-project:main Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants