Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: improve snap piece cleanup / selection #144

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Fix: improve snap piece cleanup / selection #144

merged 3 commits into from
Aug 12, 2024

Conversation

magik6k
Copy link
Collaborator

@magik6k magik6k commented Aug 12, 2024

  • Add a delete button for failed sectors in the snap pipeline page
  • Cleanup piece refs after encode in SnapDeals (this is where we finalize), this was leaving piece files around
  • Make snap sector selection if there isn't already active snap for candidate sectors

Last one was causing

2024-08-12T17:24:00.412+0200	WARN	rpc	[email protected]/handler.go:474	error in RPC call to 'Filecoin.SectorAddPieceToAny': allocating sector numbers:
    github.com/filecoin-project/curio/market.(*PieceIngesterSnap).AllocatePieceToSector
        /home/magik6k/curio/market/deal_ingest_snap.go:372
  - adding deal to sector:
    github.com/filecoin-project/curio/market.(*PieceIngesterSnap).AllocatePieceToSector.func1
        /home/magik6k/curio/market/deal_ingest_snap.go:364
  - ERROR: Conflict detected for piece_index 0 (SQLSTATE P0001)

When adding a bunch of sectors at the same time

@magik6k magik6k changed the title Fix/snap piece cleanup Fix: snap piece cleanup / selection Aug 12, 2024
@magik6k magik6k changed the title Fix: snap piece cleanup / selection Fix: improve snap piece cleanup / selection Aug 12, 2024
@magik6k magik6k force-pushed the fix/snap-piece-cleanup branch from 9d7010a to be272cb Compare August 12, 2024 15:46
@magik6k magik6k requested a review from LexLuthr August 12, 2024 16:19
LexLuthr
LexLuthr approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we were hit by the curse of transactions.

@magik6k magik6k merged commit dd31384 into main Aug 12, 2024
7 checks passed
@magik6k magik6k deleted the fix/snap-piece-cleanup branch August 12, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LexLuthr LexLuthr LexLuthr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magik6k @LexLuthr