Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration DB env #14

Merged
merged 9 commits into from
Jun 7, 2024
Merged

Migration DB env #14

merged 9 commits into from
Jun 7, 2024

Conversation

snadrus
Copy link
Contributor

@snadrus snadrus commented May 28, 2024

Create a fledgeling env file to help the curio run --layers=gui command and add doc about how to start other instances.

@snadrus snadrus force-pushed the feat/mig-db-env branch from f958a35 to 629c5ea Compare May 28, 2024 22:40
@snadrus snadrus requested a review from LexLuthr May 28, 2024 23:26
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@snadrus snadrus requested a review from LexLuthr June 5, 2024 04:03
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

cmd/curio/guidedsetup/guidedsetup.go Outdated Show resolved Hide resolved
cmd/curio/guidedsetup/guidedsetup.go Outdated Show resolved Hide resolved
cmd/curio/guidedsetup/guidedsetup.go Outdated Show resolved Hide resolved
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit

cmd/curio/guidedsetup/guidedsetup.go Show resolved Hide resolved
@LexLuthr LexLuthr mentioned this pull request Jun 6, 2024
@LexLuthr LexLuthr merged commit fa5a958 into main Jun 7, 2024
5 checks passed
@LexLuthr LexLuthr deleted the feat/mig-db-env branch June 7, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants