Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation target for completions #133

Merged
merged 7 commits into from
Aug 12, 2024

Conversation

strahe
Copy link
Contributor

@strahe strahe commented Aug 3, 2024

No description provided.

@strahe strahe marked this pull request as draft August 3, 2024 13:15
@strahe strahe force-pushed the feat/install-completions branch from 7c5372a to 7525f7e Compare August 3, 2024 13:28
@LexLuthr
Copy link
Contributor

LexLuthr commented Aug 5, 2024

@strahe Once this PR is ready for review, can you please test bash-completion with deb install as well as local build. and attach the output here?

@strahe
Copy link
Contributor Author

strahe commented Aug 6, 2024

@LexLuthr Sure, these days i have been a bit busy with nv23. After today, I will complete the testing.

@strahe
Copy link
Contributor Author

strahe commented Aug 7, 2024

Tested on Archlinux and Ubuntu 22, both bash and zsh work fine.

bash:
image

zsh:
image

@strahe strahe marked this pull request as ready for review August 7, 2024 10:00
@LexLuthr
Copy link
Contributor

LexLuthr commented Aug 9, 2024

This does not work as expected. We need a better script.

$ curio 
Display all 130 possibilities? (y or n)
(default:                                             Curio                                                 [global                                               display                                               miner                                                 separated
-                                                     Execute                                               ]                                                     enables                                               mode,                                                 setup
--color                                               Fetch                                                 a                                                     false)                                                network                                               show
--db-host                                             Filecoin                                              always                                                fetch-params                                          new                                                   start-up.
--db-name                                             GLOBAL                                                applied                                               flag                                                  node                                                  storage
--db-password                                         Incorrect                                             at                                                    for                                                   not                                                   test
--db-port                                             Manage                                                base                                                  from                                                  of                                                    testing
--db-user                                             NAME:                                                 be                                                    functions                                             on                                                    the
--help,                                               OPTIONS:                                              being                                                 guided                                                one                                                   to
--repo-path                                           Run                                                   but                                                   guided-setup                                          options]                                              use
--version,                                            Shows                                                 by                                                    h                                                     or                                                    useful
--vv                                                  Start                                                 cli                                                   help                                                  output                                                value
-generate-shell-completion                            TTY)                                                  cluster                                               help,                                                 parameters                                            verbose
-h                                                    The                                                   color                                                 hostnames                                             pipeline                                              version
-v                                                    USAGE:                                                command                                               in                                                    print                                                 very
1.23.0+mainnet+git_473bc54_2024-08-06T19:34:45+08:00  Usage:                                                commands                                              interface                                             process                                               web
127.0.0.1)                                            Utility                                               config                                                layer                                                 provided                                              will
5433)                                                 VERSION:                                              curio                                                 layers.                                               provider                                              yugabyte
CLI                                                   [,                                                    debugging                                             list                                                  proving                                               yugabyte)
COMMANDS:                                             []                                                    decentralized                                         lotus-miner                                           run                                                   ~/.curio)
Command                                               [arguments...]                                        defined:                                              market                                                seal                                                  
Creating                                              [command                                              depends                                               migrating                                             sealing          

@strahe
Copy link
Contributor Author

strahe commented Aug 9, 2024

How about this?
image

@LexLuthr
Copy link
Contributor

LexLuthr commented Aug 9, 2024

This looks better. Can you push the code?

@strahe strahe force-pushed the feat/install-completions branch from 022ed88 to a6057d7 Compare August 9, 2024 15:40
@strahe
Copy link
Contributor Author

strahe commented Aug 9, 2024

Only fixed one mistake, changed --generate-shell-completion to --generate-bash-completion

Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not working properly for sptool

# sptool sectors 
-               NAME:           USAGE:          [arguments...]  [command        command         interact        options]        sector          sectors         sptool          store           with 

scripts/completion/bash_autocomplete Show resolved Hide resolved
@strahe strahe force-pushed the feat/install-completions branch from 2ed3755 to 050e4c0 Compare August 10, 2024 13:07
@LexLuthr LexLuthr merged commit 61e8e5d into filecoin-project:main Aug 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants