no string-to-array

[snadrus]

Stop using broken YB function string_to_array()

[LexLuthr]

Postgres syntax is incorrect for lookup in array

[LexLuthr]

task_id is a bigint type in DB so we need to match that in Golang

[snadrus]

That's not a problem at all: https://www.postgresql.org/docs/current/functions-comparison.html

…

On Fri, Jul 26, 2024, 12:32 PM LexLuthr ***@***.***> wrote: ***@***.**** requested changes on this pull request. task_id is a bigint type in DB so we need to match that in Golang ------------------------------ In tasks/window/compute_task.go <#124 (comment)> : > task_id, sp_id, proving_period_start, deadline_index, partition_index - from wdpost_partition_tasks - where task_id IN (SELECT unnest(string_to_array($1, ','))::bigint)`, strings.Join(lo.Map(ids, entToStr[harmonytask.TaskID]), ",")) + FROM wdpost_partition_tasks + WHERE task_id IN ANY($1)`, lo.Map(ids, func(t harmonytask.TaskID, _ int) int { return int(t) })) ⬇️ Suggested change - WHERE task_id IN ANY($1)`, lo.Map(ids, func(t harmonytask.TaskID, _ int) int { return int(t) })) + WHERE task_id IN ANY($1)`, lo.Map(ids, func(t harmonytask.TaskID, _ int) int64 { return int64(t) })) — Reply to this email directly, view it on GitHub <#124 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOU4LXW4O4F7IFRMXIURZTZOKB3LAVCNFSM6AAAAABLQZGE7GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMBSGM2TKNZVGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>