Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct view path in notifications documentation #14314

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

Dinesh-loma
Copy link
Contributor

corrected the view path

Previous : filament-notifications.notification

correct one : notifications.notifications

path mentioned in view() was wrong. It was giving error. So I changed the path , and use correct path which was mention in example section

issue was in view path

Notification::configureUsing(function (Notification $notification): void {
    $notification->view('filament-notifications.notification');
});

Visual changes

Before :
image

After :
image

Functional changes

No functionality change. just Typo fixed

Dinesh-loma and others added 2 commits September 21, 2024 11:22
corrected the view path 

Previous : filament-notifications.notification

correct one : notifications.notifications
@zepfietje zepfietje added the documentation Improvements or additions to documentation label Sep 26, 2024
@zepfietje zepfietje added this to the v3 milestone Sep 26, 2024
@zepfietje zepfietje changed the title Update 05-customizing-notifications.md Correct view path in notifications documentation Sep 26, 2024
@zepfietje
Copy link
Member

Good catch, thanks!

@zepfietje zepfietje merged commit f8488cb into filamentphp:3.x Sep 26, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants