Support PHP 8.2 #99
Support PHP 8.2 #99
Conversation
| @@ -19,7 +19,7 @@ | |||
| "keywords": [ "x690", "x.690", "x.509", "x509", "asn1", "asn.1", "ber", "der", "binary", "encoding", "decoding" ], | |||
|
|
|||
| "require": { | |||
| "php": "~7.1.0 || ~7.2.0 || ~7.3.0 || ~7.4.0 || ~8.0.0 || ~8.1.0" | |||
| "php": "~7.1.0 || ~7.2.0 || ~7.3.0 || ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0" | |||
There was a problem hiding this comment.
hi there, I created this PR because one of our apps was not allowing the update since web-token packages depend on it. thx for your work there! 😊
I assume the review comments are more relevant for the maintainer of this package, I'll leave this up for him if you don't mind, but I can adapt it any time of course
There was a problem hiding this comment.
web-token packages depend on it
That won't be true in a few days.
| @@ -19,6 +19,7 @@ jobs: | |||
| - '7.4' | |||
| - '8.0' | |||
| - '8.1' | |||
| - '8.2' | |||
There was a problem hiding this comment.
The list could be simplified with only 7.1 and 8.2.
WDYT
|
@Spomky just i want to check with you about this PR because our App is also using this package dependency. So, Any plan to merge this PR or Any other PR which will support php8.2? |
|
Hi @glo71317, I do not act as a maintainer of this library so my actions are very limited here. |
was looking good locally, let's see if CI is green as well
oh, saw it too late, but this includes parts of #97 and is basically it's successor I guess