Skip to content
This repository has been archived by the owner on Apr 23, 2023. It is now read-only.

Change for Construct class for PHP 8.1 compatibility #87

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Change for Construct class for PHP 8.1 compatibility #87

merged 1 commit into from
Dec 9, 2021

Conversation

SilinMykola
Copy link
Contributor

Hello! We tried to update our project for PHP 8.1 compatibility but had an error with your module. I made some changes to fix compatibility with PHP8.1.

@SilinMykola
Copy link
Contributor Author

@fgrosse Hi! Could you help with this PR please?
Thank you!

@andrewbess
Copy link

Hello @fgrosse
The PHP 8.1 has been released.
Making a compatibility of our project with PHP 8.1 relates from your extension.
Could you please share your plans with releasing new version of your extension with us?
Thank you in advance.

@xmav
Copy link

xmav commented Dec 4, 2021

@afk11 @fgrosse Could you help to proceed with this ?

@stefandanaita
Copy link

@fgrosse it would be nice to get this in whenever you have some time 🙏🏻 😄

@fgrosse
Copy link
Owner

fgrosse commented Dec 9, 2021

Hey all, sorry it took a month to review but I finally took the time and the change looks fine.

@fgrosse fgrosse merged commit e0be0be into fgrosse:master Dec 9, 2021
@TimWolla
Copy link
Contributor

TimWolla commented Dec 9, 2021

@fgrosse Awesome, thank you!

@fgrosse
Copy link
Owner

fgrosse commented Dec 9, 2021

It looks like a minor change to me so I suppose bumping to v2.3.1 is the right thing? However maybe someone can confirm since I haven't touched any PHP in a long time and might misunderstand the implications of this change.

@xmav
Copy link

xmav commented Dec 9, 2021

Fantastic! Will you do release with those changes soon?

@TimWolla
Copy link
Contributor

TimWolla commented Dec 9, 2021

It looks like a minor change to me so I suppose bumping to v2.3.1 is the right thing?

@fgrosse Yes, the change is fully backwards compatible / a bugfix. It just suppresses the compatibility warning from PHP and has no other effect.

@fgrosse
Copy link
Owner

fgrosse commented Dec 9, 2021

Alright then, I also just realized there is another PR #85 which looks related. Should we try to include this in that release as well?

@TimWolla
Copy link
Contributor

TimWolla commented Dec 9, 2021

@fgrosse #85 breaks compatibility with PHP 7.0. The void type was introduced in PHP 7.1. So this would be a breaking change and should not be included. However I suggest you merge my #86 to re-enable a working CI.

@fgrosse
Copy link
Owner

fgrosse commented Dec 9, 2021

Alright thanks for the input 👍

@SilinMykola SilinMykola deleted the php-8_1-compatibility-for-construct branch January 3, 2022 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants