-
Notifications
You must be signed in to change notification settings - Fork 50
Change for Construct class for PHP 8.1 compatibility #87
Change for Construct class for PHP 8.1 compatibility #87
Conversation
@fgrosse Hi! Could you help with this PR please? |
Hello @fgrosse |
@fgrosse it would be nice to get this in whenever you have some time 🙏🏻 😄 |
Hey all, sorry it took a month to review but I finally took the time and the change looks fine. |
@fgrosse Awesome, thank you! |
It looks like a minor change to me so I suppose bumping to v2.3.1 is the right thing? However maybe someone can confirm since I haven't touched any PHP in a long time and might misunderstand the implications of this change. |
Fantastic! Will you do release with those changes soon? |
@fgrosse Yes, the change is fully backwards compatible / a bugfix. It just suppresses the compatibility warning from PHP and has no other effect. |
Alright then, I also just realized there is another PR #85 which looks related. Should we try to include this in that release as well? |
Alright thanks for the input 👍 |
Hello! We tried to update our project for PHP 8.1 compatibility but had an error with your module. I made some changes to fix compatibility with PHP8.1.