This repository has been archived by the owner on Apr 23, 2023. It is now read-only.
test for invalid input #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution Erik :) Sorry it took so long to review this, I was on vacation and then I got sick :/ |
| * @expectedExceptionMessage ASN.1 Parser Exception at offset 2: Context-Specific explicitly tagged object [1] starting at offset 2 is shorter than required in the outer tag | ||
| * @depends testFromBinary | ||
| */ | ||
| public function testFromBinaryExTagObjWithInvalidOuterLengthThrowsException2() |
There was a problem hiding this comment.
Its nice you cover all exceptions with a test. I guess you actually wanted to test the longer than allowed part in one of the testFromBinaryExTagObjWithInvalidOuterLengthThrowsException tests?
Otherwise I dont see the difference between them
There was a problem hiding this comment.
Exactly. Too much copy/paste :) I will correct that.
fgrosse
added a commit
that referenced
this pull request
Sep 15, 2015
Improve exception messages and general error handling Merges pull request #55 by Naugrimm
|
Hey Erik, your contribution is available from version 1.4.1 Thanks again 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent
E_NOTICEwhen passing invalid input toObject::fromBinary- throw Exception instead