wrap/replace eval calls with function constructor calls to make the sloppy file strict-mode compliant #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any problem in computer science can be solved by adding another layer of indirection.
This fixes all issues related with sloppy.js not being strict-mode compliant like #170 and #153
Aside from that it also provides a better separation between the evaluated code and domino as the evaluated code can no longer accidentally fall through to variables like
file
,require
or__dirname
because the function constructor code is always evaluated at top-level (where these do not exist)