Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(integration): updating RAG integration deps #583

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

devjsc
Copy link
Member

@devjsc devjsc commented Nov 22, 2024

Proposed Changes

Integration doesn't seem to work locally when importing Field from Pydantic but works with uAgents, and cohere imports were not playing well.

Linked Issues

[if applicable, add links to issues resolved by this PR]

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • [ x] I have read the CONTRIBUTING guide
  • [ x] Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have added/updated the documentation (executed the script in python/scripts/generate_api_docs.py)

Further comments

[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]

@devjsc devjsc changed the title chore(integration): updating import Filed from uagnts not pydantic chore(integration): updating import Fiekd from uagents not pydantic Nov 22, 2024
@devjsc devjsc changed the title chore(integration): updating import Fiekd from uagents not pydantic chore(integration): updating RAG integration deps Nov 22, 2024
Copy link
Contributor

@Dacksus Dacksus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update from pydantic Fields to uagents Fields was announced in one of the recent releases, but obviously could have been made more visible

@devjsc devjsc merged commit 5e55a0d into fetchai:main Nov 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants