Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy checks + fixes #217

Merged
merged 57 commits into from
Dec 16, 2022
Merged

Mypy checks + fixes #217

merged 57 commits into from
Dec 16, 2022

Conversation

MissingNO57
Copy link

@MissingNO57 MissingNO57 commented Dec 9, 2022

  • Additional linting checks (MyPy)

  • removed
    repo_root_path = Path(__file__).parent.parent.parent.absolute() sys.path.insert(0, str(repo_root_path))


Code Review Checklist (to be filled out by reviewer)

  • Description accurately reflects what changes are being made.
  • Either the PR references an issue (via the "Development" combobox) or the description explains the need for the changes.
  • The PR appropriately sized.
  • The PR contains an idempotent DB migration.
  • I have verified the correctness of the DB migration using relevant data (e.g. test-generated data).
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

@MissingNO57 MissingNO57 changed the title [WiP] Mypy checks + fixes Mypy checks + fixes Dec 9, 2022
Copy link

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MissingNO57! 🙌

@MissingNO57 MissingNO57 merged commit a020f5d into main Dec 16, 2022
@MissingNO57 MissingNO57 deleted the feature/cl-additoinal-checks branch December 16, 2022 10:32
bryanchriswhite added a commit that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants