Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to wasmd 1.0 #20

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Upgrade to wasmd 1.0 #20

merged 2 commits into from
Aug 27, 2020

Conversation

jinmannwong
Copy link
Contributor

No description provided.

n-hutton
n-hutton suggested changes Aug 27, 2020
View reviewed changes
Dockerfile Outdated
@@ -1,3 +1,4 @@
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a bad merge here - would a make build have caught this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this. Also no, make build doesn't catch this.

Dockerfile Outdated
@@ -40,5 +92,9 @@ STOPSIGNAL SIGTERM

FROM hub as gcr

<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

@jinmannwong jinmannwong requested a review from n-hutton August 27, 2020 13:26
@jinmannwong jinmannwong merged commit 45f0af7 into fetchai:master Aug 27, 2020
@jinmannwong jinmannwong deleted the port_wasm_10 branch August 27, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n-hutton n-hutton n-hutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinmannwong @n-hutton