feat: leave some tokens on delegator accounts for txs #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise, tokens are simply transfered on the user account and no delegation is created.
daeMOn63
commented
Jul 5, 2021
| return fmt.Errorf("failed to get flag %q: %w", flagAccountReservedAmount, err) | ||
| } | ||
|
|
||
| minDelegatedCoin, err := sdk.ParseCoinNormalized(minDelegatedAmountStr) |
There was a problem hiding this comment.
@ejfitzgerald this ParseCoinNormalized will truncate amount decimals:
873355710070564895.14afet becomes 873355710070564895afet
This seems the regular way to parse coin amount input, but not sure about losing some precision here, wdyt?
There was a problem hiding this comment.
Yep totally fine. Technically speaking there is no such thing as fractial afet so this truncation is fine
ejfitzgerald
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add condition to create delegations:
minDelegatedamount, a delegation is created withamount - accountReserved, andaccountReservedis transferred on the user account.